Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use bazel workers for ngc and tsc in local development #32246

Closed
wants to merge 1 commit into from

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Aug 21, 2019

Uses the worker strategy for ngc and tsc in local development. Quick analysis of time savings

Build command executed:
yarn bazel build //packages/core/test/acceptance:acceptance --define=compile=aot

Clean Build - 33.1% faster

Before:

real    1m39.631s
user    0m0.285s
sys     0m0.088s

After:

real    1m6.712s
user    0m0.283s
sys     0m0.106s

Rebuild - 47% faster

Rebuilds were done with a trivial comment added to packages/core/test/acceptance/attributes_spec.ts

Before:

real    0m10.089s
user    0m0.271s
sys     0m0.119s

After:

real    0m5.265s
user    0m0.276s
sys     0m0.116s

@josephperrott josephperrott requested a review from a team as a code owner August 21, 2019 20:09
@josephperrott josephperrott added target: major This PR is targeted for the next major release and removed cla: yes labels Aug 21, 2019
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed cla: yes labels Aug 21, 2019
@atscott atscott closed this in a84b5ef Aug 21, 2019
ngdevelop-tech pushed a commit to ngdevelop-tech/angular that referenced this pull request Aug 27, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants